Skip to content

Conversation

@Laure-di
Copy link
Contributor

No description provided.

@Laure-di Laure-di self-assigned this Jun 10, 2025
@Laure-di Laure-di requested review from a team and remyleone as code owners June 10, 2025 15:29
@Laure-di Laure-di marked this pull request as draft June 10, 2025 15:29
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Jun 10, 2025
@Laure-di Laure-di force-pushed the filestorage-instance branch 15 times, most recently from 8bdb428 to d38c38c Compare June 16, 2025 08:55
@Laure-di Laure-di force-pushed the filestorage-instance branch from d1820ce to 3575502 Compare June 16, 2025 12:53
@Laure-di Laure-di modified the milestone: Blocked Jun 26, 2025
@Laure-di Laure-di force-pushed the filestorage-instance branch from 95b449a to e7257a2 Compare July 2, 2025 08:34
@Laure-di Laure-di force-pushed the filestorage-instance branch from 7a990cb to b403f18 Compare October 21, 2025 15:27
@github-actions github-actions bot added the file Filesystem issues, bugs and feature requests label Oct 21, 2025
@Laure-di Laure-di force-pushed the filestorage-instance branch 2 times, most recently from 3e9e916 to 40d724d Compare October 21, 2025 15:32
@Laure-di Laure-di marked this pull request as ready for review October 21, 2025 15:32
feat(file): add support v1beta1

Create, Read and Update function

Delete Methode

add tests

fix date issue and register cassettes

test: add validation for filesystem size granularity

fix: convertion

fix(instance): update schema filesystem

test(instance): add test attach filesystem

feat(instance): delete and update filesystem

chore: master sdk-go

go mod tidy

update doc and tests

fix fmt

update go.mod

fix(file): rename attribut size to size_in_gb

fix: error return attachFS and typo doc

fix: error return attachFS and typo doc

update FileSystem Size to GB

update FileSystem Size to GB

refacto waiter

tests: fix test and add waiter
@Laure-di Laure-di force-pushed the filestorage-instance branch 6 times, most recently from c76da52 to 0d69883 Compare October 22, 2025 09:44
@Laure-di Laure-di force-pushed the filestorage-instance branch from 0d69883 to 0fe4a2f Compare October 22, 2025 09:49
@Laure-di Laure-di removed the blocked label Oct 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 0% with 144 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.80%. Comparing base (6fdd6f5) to head (2971b09).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/instance/server.go 0.00% 67 Missing ⚠️
internal/services/instance/helpers_instance.go 0.00% 38 Missing ⚠️
internal/services/file/filesystem.go 0.00% 15 Missing ⚠️
internal/services/instance/waiters.go 0.00% 13 Missing ⚠️
internal/services/instance/types.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3149      +/-   ##
=========================================
- Coverage    1.81%   1.80%   -0.02%     
=========================================
  Files         390     390              
  Lines       51437   51573     +136     
=========================================
- Hits          936     930       -6     
- Misses      50419   50559     +140     
- Partials       82      84       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di force-pushed the filestorage-instance branch 2 times, most recently from 6bacbfb to 06aeacc Compare October 22, 2025 14:55
remyleone
remyleone previously approved these changes Oct 22, 2025
@remyleone remyleone added this pull request to the merge queue Oct 22, 2025
Merged via the queue into scaleway:master with commit 6278d71 Oct 22, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file Filesystem issues, bugs and feature requests instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants